linux-kernel - Re: [PATCH] x86/cpu: Consolidate identical branches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 09:59:23 +0300
From: Nikolay Borisov <nik.borisov@...e.com>
To: x86@...nel.org
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/cpu: Consolidate identical branches



On 21.05.24 г. 15:48 ч., Nikolay Borisov wrote:
> It's pointless to have 2 identical branches one after the other, simply
> collapse them in a single branch. No functional changes.
> 
> Signed-off-by: Nikolay Borisov <nik.borisov@...e.com>

Ping

> ---
>   arch/x86/kernel/cpu/common.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 69265c0acaea..369037a166fd 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -1732,12 +1732,11 @@ static void generic_identify(struct cpuinfo_x86 *c)
>   {
>   	c->extended_cpuid_level = 0;
>   
> -	if (!have_cpuid_p())
> +	if (!have_cpuid_p()) {
>   		identify_cpu_without_cpuid(c);
> -
> -	/* cyrix could have cpuid enabled via c_identify()*/
> -	if (!have_cpuid_p())
> +		/* cyrix could have cpuid enabled via c_identify()*/
>   		return;
> +	}
>   
>   	cpu_detect(c);
>