linux-kernel - Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d7164356496ab910bdbcac471f91d874b9e075d.camel@gmail.com>
Date: Mon, 10 Jun 2024 09:11:28 +0200
From: Nuno Sá <noname.nuno@...il.com>
To: Jonathan Cameron <jic23@...nel.org>, Nuno Sa <nuno.sa@...log.com>
Cc: Petr Mladek <pmladek@...e.com>, Lars-Peter Clausen <lars@...afoo.de>, 
 Olivier Moysan <olivier.moysan@...s.st.com>, Jyoti Bhayana
 <jbhayana@...gle.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Chris Down <chris@...isdown.name>, John Ogness <john.ogness@...utronix.de>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Andi Shyti
 <andi.shyti@...nel.org>, linux-kernel@...r.kernel.org, 
 linux-iio@...r.kernel.org
Subject: Re: [PATCH v3 2/4] iio: temperature: ltc2983: convert to
 dev_err_probe()

On Sat, 2024-06-08 at 19:06 +0100, Jonathan Cameron wrote:
> On Thu, 6 Jun 2024 09:22:38 +0200
> Nuno Sa <nuno.sa@...log.com> wrote:
> 
> > Use dev_err_probe() (and variants) in the probe() path. While at it, made
> > some simple improvements:
> >  * Explicitly included the err.h and errno.h headers;
> >  * Removed some unnecessary line breaks;
> >  * Removed a redundant 'else';
> >  * Added some missing \n to prink.
> > 
> > Signed-off-by: Nuno Sa <nuno.sa@...log.com>
> > ---
> 
> 
> > @@ -1296,8 +1268,8 @@ static int ltc2983_reg_access(struct iio_dev
> > *indio_dev,
> >  
> >  	if (readval)
> >  		return regmap_read(st->regmap, reg, readval);
> > -	else
> > -		return regmap_write(st->regmap, reg, writeval);
> > +
> > +	return regmap_write(st->regmap, reg, writeval);
> >  }
> 
> Unrelated.
> 
> Otherwise updates look correct to me.

Yeah, I know. It was simple enough that I sneaked it in and did mentioned it in
the commit message hoping it would make the change acceptable in here :)

- Nuno Sá