linux-kernel - Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 09:37:56 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Frank Li <Frank.li@....com>
Cc: andersson@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org,
 festevam@...il.com, imx@...ts.linux.dev, kernel@...gutronix.de,
 krzk+dt@...nel.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org,
 mathieu.poirier@...aro.org, peng.fan@....com, robh@...nel.org,
 s.hauer@...gutronix.de, shawnguo@...nel.org
Subject: Re: [PATCH v2 1/1] dt-bindings: remoteproc: imx_rproc: add minItems
 for power-domain

On 07/06/2024 17:19, Frank Li wrote:
> On Fri, Jun 07, 2024 at 09:32:26AM +0200, Krzysztof Kozlowski wrote:
>> On 06/06/2024 17:00, Frank Li wrote:
>>> "fsl,imx8qxp-cm4" and "fsl,imx8qm-cm4" need minimum 2 power domains. Keep
>>> the same restriction for other compatible string.
>>>
>>> Signed-off-by: Frank Li <Frank.Li@....com>
>>> ---
>>>
>>> Notes:
>>>     Change from v1 to v2
>>>     - set minitem to 2 at top
>>>     - Add imx8qm compatible string also
>>>     - use not logic to handle difference compatible string restriction
>>>     - update commit message.
>>>     
>>>     pass dt_binding_check.
>>>     
>>>     make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -j8  dt_binding_check DT_SCHEMA_FILES=fsl,imx-rproc.yaml
>>>       SCHEMA  Documentation/devicetree/bindings/processed-schema.json
>>>       CHKDT   Documentation/devicetree/bindings
>>>       LINT    Documentation/devicetree/bindings
>>>       DTEX    Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dts
>>>       DTC_CHK Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.example.dtb
>>>
>>>  .../bindings/remoteproc/fsl,imx-rproc.yaml         | 14 ++++++++++++++
>>>  1 file changed, 14 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
>>> index df36e29d974ca..da108a39df435 100644
>>> --- a/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
>>> +++ b/Documentation/devicetree/bindings/remoteproc/fsl,imx-rproc.yaml
>>> @@ -59,6 +59,7 @@ properties:
>>>      maxItems: 32
>>>  
>>>    power-domains:
>>> +    minItems: 2
>>>      maxItems: 8
>>>  
>>>    fsl,auto-boot:
>>> @@ -99,6 +100,19 @@ allOf:
>>>        properties:
>>>          fsl,iomuxc-gpr: false
>>>  
>>> +  - if:
>>> +      properties:
>>> +        compatible:
>>> +          not:
>>> +            contains:
>>> +              enum:
>>> +                - fsl,imx8qxp-cm4
>>> +                - fsl,imx8qm-cm4
>>> +    then:
>>> +      properties:
>>> +        power-domains:
>>> +          minItems: 8
>>
>> What happened with the "else:"? How many power domains is needed for
>> other devices?
> 
> So far, only fsl,imx8qxp-cm4 ind fsl,imx8qm-cm4 need power domain (2-8). 
> Power-domains is option property. 
> 
> Can I just remove whole "if"?

No, I rather expect else.

Best regards,
Krzysztof