linux-kernel - Re: [PATCH] fs/ufs: Use LUT for dir entry types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0485dd2d-488a-40e9-b0f7-24236b9c00ab@web.de>
Date: Mon, 10 Jun 2024 09:48:09 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Luis Felipe Hernandez <luis.hernandez093@...il.com>,
 linux-kernel-mentees@...ts.linuxfoundation.org,
 Evgeniy Dushistov <dushistov@...l.ru>, Shuah Khan <skhan@...uxfoundation.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs/ufs: Use LUT for dir entry types

> As per the original TODO, replacing the switch statement with a lookup
> table results in more concise mapping logic and improved performance.
…

Can imperative wordings be relevant for another improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94


…
> +++ b/fs/ufs/util.h
…
>  static inline void
>  ufs_set_de_type(struct super_block *sb, struct ufs_dir_entry *de, int mode)
…
> +	if (mode_index < ARRAY_SIZE(ufs_mode_to_dt))
> +		de->d_u.d_44.d_type = ufs_mode_to_dt[mode_index];
> +	else
>  		de->d_u.d_44.d_type = DT_UNKNOWN;
…

May a conditional operator expression be applied at this source code place?

Regards,
Markus