linux-kernel - Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d3b9f4b5-2c21-4f55-a189-c6250ff8eba2@kernel.org>
Date: Mon, 10 Jun 2024 10:11:22 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Danila Tikhonov <danila@...xyga.com>, neil.armstrong@...aro.org,
 quic_jesszhan@...cinc.com, sam@...nborg.org,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, daniel@...ll.ch, robh@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org
Cc: dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, adrian@...vitia.xyz, degdagmohamed@...il.com
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Samsung AMS639RQ08

On 09/06/2024 22:36, Danila Tikhonov wrote:
> The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode
> AMOLED panel used in:
> - Xiaomi Mi 9 Lite / CC9 (sdm710-xiaomi-pyxis)
> - Xiaomi Mi 9T / Redmi K20 (sm7150-xiaomi-davinci)
> - Xiaomi Mi 9T Pro / Redmi K20 Pro (sm8150-xiaomi-raphael)
> Add a dt-binding for it.
> 
> Signed-off-by: Danila Tikhonov <danila@...xyga.com>

If there is going to be any new posting, then two changes:


> +maintainers:
> +  - Danila Tikhonov <danila@...xyga.com>
> +  - Jens Reidel <adrian@...vitia.xyz>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The Samsung AMS639RQ08 is a 6.39 inch 1080x2340 MIPI-DSI CMD mode AMOLED panel.
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: samsung,ams639rq08
> +
> +  reg:
> +    maxItems: 1
> +
> +  vdd3p3-supply:
> +    description: 3.3V source voltage rail
> +
> +  vddio-supply:
> +    description: I/O source voltage rail
> +
> +  vsn-supply:
> +    description: Positive source voltage rail
> +
> +  vsp-supply:
> +    description: Negative source voltage rail
> +
> +  reset-gpios: true
> +  port: true
> +
> +additionalProperties: false

This goes after "required:" block.

> +
> +required:
> +  - compatible
> +  - reg
> +  - vdd3p3-supply
> +  - vddio-supply
> +  - vsn-supply
> +  - vsp-supply
> +  - reset-gpios
> +  - port
> +

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof