[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f32847c0-6c15-4d17-805f-03d2ad62aae5@kernel.org>
Date: Mon, 10 Jun 2024 10:59:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Laurentiu Mihalcea <laurentiumihalcea111@...il.com>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>, Liu Ying <victor.liu@....com>,
Sascha Hauer <s.hauer@...gutronix.de>
Cc: laurentiu.mihalcea@....com, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: reset: add schema for imx8ulp SIM
reset
On 09/06/2024 14:58, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
>
> Add schema for imx8ulp's SIM reset controller.
>
> Signed-off-by: Liu Ying <victor.liu@....com>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@....com>
> ---
> .../bindings/reset/nxp,imx8ulp-sim-reset.yaml | 68 +++++++++++++++++++
> 1 file changed, 68 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml
>
> diff --git a/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml
> new file mode 100644
> index 000000000000..e7faec55ff36
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml
Use compatible as filename.
> @@ -0,0 +1,68 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/nxp,imx8ulp-sim-reset.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NXP i.MX8ULP System Integration Module Reset Controller
> +
> +maintainers:
> + - Liu Ying <victor.liu@....com>
> +
> +description: |
Do not need '|' unless you need to preserve formatting.
> + Some instances of i.MX8ULP's SIM may offer control
> + over the reset of some components of a certain domain
> + (e.g: AVD-SIM).
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - nxp,imx8ulp-avd-sim-reset
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + mux-controller:
> + $ref: ../mux/reg-mux.yaml
Full path, so /schemas/mux/reg-mux.yaml#
> +
> +required:
> + - compatible
> + - reg
> + - '#reset-cells'
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: nxp,imx8ulp-avd-sim-reset
> + then:
> + required:
> + - mux-controller
> + - clocks
This does not make much sense. You do not have other variants.
> +
> +additionalProperties: false
Best regards,
Krzysztof
Powered by blists - more mailing lists