linux-kernel - Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6cc32fceb4d74833e045e0acbc51515b5ef3065b.camel@posteo.de>
Date: Mon, 10 Jun 2024 10:17:55 +0000
From: Martin Kepplinger <martink@...teo.de>
To: Guido Günther <agx@...xcpu.org>, Rob Herring
 <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, 
 Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
 imx@...ts.linux.dev,  linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org,  phone-devel@...r.kernel.org, kernel@...i.sm
Subject: Re: [PATCH] dts: imx8mq-librem5: Don't wake up on volume key press

Am Montag, dem 20.05.2024 um 12:57 +0200 schrieb Guido Günther:
> The only key that should wake up the phone is power button press.
> This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
> 
> Signed-off-by: Guido Günther <agx@...xcpu.org>

Reviewed-by: Martin Kepplinger <martink@...teo.de>

thank you,

                              martin

> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ffb5fe61630d..1b39514d5c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -45,7 +45,6 @@ key-vol-down {
>                         gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEDOWN>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>  
>                 key-vol-up {
> @@ -53,7 +52,6 @@ key-vol-up {
>                         gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEUP>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>         };
>