linux-kernel - Re: [PATCH v2] drm/bridge: it6505: remove unnecessary NULL checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171801944880.382402.4293639602145071155.b4-ty@kernel.org>
Date: Mon, 10 Jun 2024 13:37:28 +0200
From: Robert Foss <rfoss@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>, Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Andrzej Hajda <andrzej.hajda@...el.com>
Cc: Neil Armstrong <neil.armstrong@...aro.org>, Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
 David Airlie <airlied@...il.com>, Jonas Karlman <jonas@...boo.se>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>,
 linux-kernel@...r.kernel.org, Jernej Skrabec <jernej.skrabec@...il.com>, Maxime Ripard <mripard@...nel.org>,
 Thomas Zimmermann <tzimmermann@...e.de>, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] drm/bridge: it6505: remove unnecessary NULL checks

On Mon, 10 Jun 2024 13:50:26 +0300, Dan Carpenter wrote:
> Smatch complains correctly that the NULL checking isn't consistent:
> 
>     drivers/gpu/drm/bridge/ite-it6505.c:2583 it6505_poweron()
>     error: we previously assumed 'pdata->pwr18' could be null
>     (see line 2569)
> 
> These the ->pwr18 pointer is allocated during probe using the
> devm_regulator_get() function.  If CONFIG_REGULATOR is disabled then,
> yes, it can return NULL but in that case regulator_enable() and
> disable() functions are no-ops so passing a NULL pointer is okay.
> 
> [...]

Applied, thanks!

[1/1] drm/bridge: it6505: remove unnecessary NULL checks
      (no commit info)



Rob