linux-kernel - Re: [PATCH 1/1] ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 14:27:58 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Christophe ROULLIER <christophe.roullier@...s.st.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh+dt@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Richard Cochran <richardcochran@...il.com>, Jose Abreu
 <joabreu@...opsys.com>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Marek Vasut <marex@...x.de>
Cc: netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support

On 10/06/2024 10:14, Christophe ROULLIER wrote:
>>> @@ -469,6 +469,7 @@ CONFIG_SPI_XILINX=y
>>>   CONFIG_SPI_SPIDEV=y
>>>   CONFIG_SPMI=y
>>>   CONFIG_PINCTRL_AS3722=y
>>> +CONFIG_PINCTRL_MCP23S08=y
>> This is not an on-SoC pinctrl, so it should be module (=m).
> 
> The stmmac is in built-in, if IO-Expander (MCP23S08) is on module, we 
> have huge of message during kernel boot
> 
> because stmmac driver is deferred several times. (need to wait that 
> module are ready)

Which is normal and not a reason to change defconfig. It it was a
problem, you should solve it not in defconfig but in kernel. That's just
defconfig, an example, reference or debugging tool if you wish, so
fixing issue here is not a fix at all.

Best regards,
Krzysztof