[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <831dc04b-d257-4c99-9645-7aa18e3b764b@linaro.org>
Date: Mon, 10 Jun 2024 14:53:20 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Adam Skladowski <a39.skl@...il.com>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht,
Andy Gross <agross@...nel.org>, Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>, Georgi Djakov <djakov@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-arm-msm@...r.kernel.org,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/7] dt-bindings: interconnect: Add Qualcomm MSM8937 DT
bindings
On 09/06/2024 20:20, Adam Skladowski wrote:
> Add bindings for Qualcomm MSM8937 Network-On-Chip interconnect devices.
>
> Signed-off-by: Adam Skladowski <a39.skl@...il.com>
Since I expect resend, all trivial nits from patch #1 apply here as well.
> ---
> .../bindings/interconnect/qcom,msm8937.yaml | 81 ++++++++++++++++
> .../dt-bindings/interconnect/qcom,msm8937.h | 93 +++++++++++++++++++
> 2 files changed, 174 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,msm8937.yaml
> create mode 100644 include/dt-bindings/interconnect/qcom,msm8937.h
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,msm8937.yaml b/Documentation/devicetree/bindings/interconnect/qcom,msm8937.yaml
> new file mode 100644
> index 000000000000..39a1ca441bb2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,msm8937.yaml
> @@ -0,0 +1,81 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,msm8937.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm MSM8937 Network-On-Chip interconnect
> +
> +maintainers:
> + - Konrad Dybcio <konradybcio@...nel.org>
> +
> +description: |
> + The Qualcomm MSM8937 interconnect providers support adjusting the
> + bandwidth requirements between the various NoC fabrics.
> +
> +allOf:
> + - $ref: qcom,rpm-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,msm8937-bimc
> + - qcom,msm8937-pcnoc
> + - qcom,msm8937-snoc
> +
> + reg:
> + maxItems: 1
> +
> +patternProperties:
> + '^interconnect-[a-z0-9\-]+$':
> + type: object
> + $ref: qcom,rpm-common.yaml#
> + description:
> + The interconnect providers do not have a separate QoS register space,
> + but share parent's space.
> +
> + allOf:
> + - $ref: qcom,rpm-common.yaml#
> +
> + properties:
> + compatible:
> + const: qcom,msm8937-snoc-mm
> +
> + required:
> + - compatible
> +
> + unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmcc.h>
> + #include <dt-bindings/interconnect/qcom,rpm-icc.h>
> +
> + bimc: interconnect@...000 {
> + compatible = "qcom,msm8937-bimc";
> + reg = <0x00400000 0x5a000>;
> + #interconnect-cells = <2>;
> + };
Drop node
> +
> + pcnoc: interconnect@...000 {
> + compatible = "qcom,msm8937-pcnoc";
> + reg = <0x00500000 0x13080>;
> + #interconnect-cells = <2>;
> + };
Drop node
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists