linux-kernel - Re: [PATCH] regulator: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fdf878a7-a2c9-431e-a5c2-c7ba328c1fb3@quicinc.com>
Date: Mon, 10 Jun 2024 07:22:50 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Support Opensource <support.opensource@...semi.com>,
        Liam Girdwood
	<lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
        Matthias Brugger
	<matthias.bgg@...il.com>
CC: <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] regulator: add missing MODULE_DESCRIPTION() macro

On 6/10/2024 1:43 AM, AngeloGioacchino Del Regno wrote:
> Il 09/06/24 06:53, Jeff Johnson ha scritto:
>> On x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/regulator/da9121-regulator.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/regulator/max20411-regulator.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/regulator/rt4831-regulator.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/regulator/tps6286x-regulator.o
>>
>> Add the missing invocation of the MODULE_DESCRIPTION() macro to all files
>> which have a MODULE_LICENSE(). This includes mtk-dvfsrc-regulator.c, which
>> did not produce a warning with the x86 allmodconfig, since it may cause
>> this warning with other configurations.
>>
>> Signed-off-by: Jeff Johnson <quic_jjohnson@...cinc.com>
>> ---
>>   drivers/regulator/da9121-regulator.c     | 1 +
>>   drivers/regulator/max20411-regulator.c   | 1 +
>>   drivers/regulator/mtk-dvfsrc-regulator.c | 1 +
>>   drivers/regulator/rt4831-regulator.c     | 1 +
>>   drivers/regulator/tps6286x-regulator.c   | 1 +
>>   5 files changed, 5 insertions(+)
>>
>> diff --git a/drivers/regulator/da9121-regulator.c b/drivers/regulator/da9121-regulator.c
>> index 96257551bb12..3571b6242e3a 100644
>> --- a/drivers/regulator/da9121-regulator.c
>> +++ b/drivers/regulator/da9121-regulator.c
>> @@ -1192,4 +1192,5 @@ static struct i2c_driver da9121_regulator_driver = {
>>   
>>   module_i2c_driver(da9121_regulator_driver);
>>   
>> +MODULE_DESCRIPTION("Dialog Semiconductor DA9121/DA9122/DA9220/DA9217/DA9130/DA9131/DA9132 regulator driver");
>>   MODULE_LICENSE("GPL v2");
>> diff --git a/drivers/regulator/max20411-regulator.c b/drivers/regulator/max20411-regulator.c
>> index 8c09dc71b16d..6614e767072f 100644
>> --- a/drivers/regulator/max20411-regulator.c
>> +++ b/drivers/regulator/max20411-regulator.c
>> @@ -161,4 +161,5 @@ static struct i2c_driver max20411_i2c_driver = {
>>   };
>>   module_i2c_driver(max20411_i2c_driver);
>>   
>> +MODULE_DESCRIPTION("Maxim MAX20411 High-Efficiency Single Step-Down Converter driver");
>>   MODULE_LICENSE("GPL");
>> diff --git a/drivers/regulator/mtk-dvfsrc-regulator.c b/drivers/regulator/mtk-dvfsrc-regulator.c
>> index f1280d45265d..1941aad5e247 100644
>> --- a/drivers/regulator/mtk-dvfsrc-regulator.c
>> +++ b/drivers/regulator/mtk-dvfsrc-regulator.c
>> @@ -211,4 +211,5 @@ static void __exit mtk_dvfsrc_regulator_exit(void)
>>   module_exit(mtk_dvfsrc_regulator_exit);
>>   
>>   MODULE_AUTHOR("Arvin wang <arvin.wang@...iatek.com>");
>> +MODULE_DESCRIPTION("MediaTek DVFSRC regulator driver");
> 
> Can you please drop this one?
> I have a series floating that is removing this driver entirely and replacing it
> with a refactored one. Though, it has the same issue, so I'll have to send a v6.
> 
> Anyway, v5 is there:
> 
> https://lore.kernel.org/r/20240424095416.1105639-1-angelogioacchino.delregno@collabora.com
> 
> 
>>   MODULE_LICENSE("GPL v2");
>> diff --git a/drivers/regulator/rt4831-regulator.c b/drivers/regulator/rt4831-regulator.c
>> index 97e6f7e2a0ba..7d1ba0c82271 100644
>> --- a/drivers/regulator/rt4831-regulator.c
>> +++ b/drivers/regulator/rt4831-regulator.c
>> @@ -202,4 +202,5 @@ static struct platform_driver rt4831_regulator_driver = {
>>   module_platform_driver(rt4831_regulator_driver);
>>   
>>   MODULE_AUTHOR("ChiYuan Huang <cy_huang@...htek.com>");
>> +MODULE_DESCRIPTION("Richtek RT4831 DSV RegulatorsRichtek RT4831 DSV Regulators driver");
> 
> Also, there's a typo here :-)
> 
> After dropping mtk-dvfsrc-regulator changes and after fixing the typo:
> 
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Thanks, will address these in v2

/jeff