linux-kernel - Re: [PATCH v2] scsi: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 07:57:20 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Hannes Reinecke <hare@...e.com>, Khalid Aziz <khalid@...ehiking.org>,
        "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
        "Martin K.
 Petersen" <martin.petersen@...cle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Finn Thain <fthain@...ux-m68k.org>,
        Michael Schmitz <schmitzmic@...il.com>,
        James Smart <james.smart@...adcom.com>,
        Ram Vegesna
	<ram.vegesna@...adcom.com>,
        Artur Paszkiewicz <artur.paszkiewicz@...el.com>,
        "Juergen E. Fischer" <fischer@...bit.de>
CC: <linux-scsi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <target-devel@...r.kernel.org>, <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH v2] scsi: add missing MODULE_DESCRIPTION() macros

On 6/9/2024 11:10 PM, Hannes Reinecke wrote:
> On 6/8/24 17:33, Jeff Johnson wrote:
[...]
>> diff --git a/drivers/scsi/aha1542.c b/drivers/scsi/aha1542.c
>> index 9503996c6325..add10098a569 100644
>> --- a/drivers/scsi/aha1542.c
>> +++ b/drivers/scsi/aha1542.c
>> @@ -1009,6 +1009,7 @@ static int aha1542_biosparam(struct scsi_device *sdev,
>>   
>>   	return 0;
>>   }
>> +MODULE_DESCRIPTION("Adaptec AHA-1542 SCSI host adapter driver");
>>   MODULE_LICENSE("GPL");
> 
> Please add a newline before the MODULE_DESCRIPTION line.
> 
>>   
>>   static int aha1542_init_cmd_priv(struct Scsi_Host *shost, struct scsi_cmnd *cmd)
[...]
>> --- a/drivers/scsi/atp870u.c
>> +++ b/drivers/scsi/atp870u.c
>> @@ -1724,6 +1724,7 @@ static void atp870u_remove (struct pci_dev *pdev)
>>   	atp870u_free_tables(pshost);
>>   	scsi_host_put(pshost);
>>   }
>> +MODULE_DESCRIPTION("ACARD SCSI host adapter driver");
>>   MODULE_LICENSE("GPL");
> 
> Again, missing newline.

I'll update these in v2