linux-kernel - Re: [PATCH v9 2/2] power: pwrseq: add a driver for the PMU module on the QCom WCN chipsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc56ecb2-9940-48b5-afbc-1a447b1ff46f@linaro.org>
Date: Mon, 10 Jun 2024 17:07:02 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Bartosz Golaszewski <brgl@...ev.pl>, Marcel Holtmann
 <marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>,
 "David S . Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Kalle Valo <kvalo@...nel.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
 Bjorn Helgaas <bhelgaas@...gle.com>, Saravana Kannan <saravanak@...gle.com>,
 Geert Uytterhoeven <geert+renesas@...der.be>, Arnd Bergmann <arnd@...db.de>,
 Neil Armstrong <neil.armstrong@...aro.org>,
 Marek Szyprowski <m.szyprowski@...sung.com>, Alex Elder <elder@...aro.org>,
 Srini Kandagatla <srinivas.kandagatla@...aro.org>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Abel Vesa <abel.vesa@...aro.org>, Manivannan Sadhasivam <mani@...nel.org>,
 Lukas Wunner <lukas@...ner.de>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 Amit Pundir <amit.pundir@...aro.org>, Xilin Wu <wuxilin123@...il.com>
Cc: linux-bluetooth@...r.kernel.org, netdev@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-wireless@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-pci@...r.kernel.org,
 linux-pm@...r.kernel.org,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 Caleb Connolly <caleb.connolly@...aro.org>
Subject: Re: [PATCH v9 2/2] power: pwrseq: add a driver for the PMU module on
 the QCom WCN chipsets

On 10/06/2024 17:05, Krzysztof Kozlowski wrote:
> On 05/06/2024 14:38, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>>
>> This adds the power sequencing driver for the PMU modules present on the
>> Qualcomm WCN Bluetooth and Wifi chipsets. It uses the pwrseq subsystem
>> and knows how to match the sequencer to the consumer device by verifying
>> the relevant properties and DT layout. Using this driver will allow the
>> BT and WLAN drivers to respect the required delays between enabling the
>> two modules.
>>
> 
> ...
> 
> 
>> +
>> +	ctx->bt_gpio = devm_gpiod_get_optional(dev, "bt-enable", GPIOD_OUT_LOW);
>> +	if (IS_ERR(ctx->bt_gpio))
>> +		return dev_err_probe(dev, PTR_ERR(ctx->bt_gpio),
>> +				     "Failed to get the Bluetooth enable GPIO\n");
>> +
>> +	ctx->wlan_gpio = devm_gpiod_get_optional(dev, "wlan-enable",
>> +						 GPIOD_OUT_LOW);
>> +	if (IS_ERR(ctx->wlan_gpio))
>> +		return dev_err_probe(dev, PTR_ERR(ctx->wlan_gpio),
>> +				     "Failed to get the WLAN enable GPIO\n");
>> +
>> +	ctx->clk = devm_clk_get_optional(dev, NULL);
> 
> Your binding does not allow the clock. Do you need it for non-DT platforms?

Bah, damn covid, now I see second commit with clocks.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof