linux-kernel - Re: [PATCH v4 1/4] dt-bindings: mfd: Add Analog Devices ADP5585

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 10 Jun 2024 18:34:39 +0300
From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
To: Stanislav Jakubek <stano.jakubek@...il.com>
Cc: brgl@...ev.pl, conor+dt@...nel.org, devicetree@...r.kernel.org,
	krzk+dt@...nel.org, lee@...nel.org, linus.walleij@...aro.org,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-pwm@...r.kernel.org, robh@...nel.org, ukleinek@...nel.org
Subject: Re: [PATCH v4 1/4] dt-bindings: mfd: Add Analog Devices ADP5585

Hi Stanislav,

On Mon, Jun 10, 2024 at 08:21:09AM +0200, Stanislav Jakubek wrote:
> Hi Laurent,
> 
> > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
> > index 0a419453d183..91e62df4b296 100644
> > --- a/Documentation/devicetree/bindings/trivial-devices.yaml
> > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
> > @@ -39,10 +39,6 @@ properties:
> >              # AD5110 - Nonvolatile Digital Potentiometer
> >            - adi,ad5110
> >              # Analog Devices ADP5585 Keypad Decoder and I/O Expansion
> > -          - adi,adp5585
> > -            # Analog Devices ADP5585 Keypad Decoder and I/O Expansion with support for Row5
> > -          - adi,adp5585-02
> > -            # Analog Devices ADP5589 Keypad Decoder and I/O Expansion
> >            - adi,adp5589
> >              # Analog Devices LT7182S Dual Channel 6A, 20V PolyPhase Step-Down Silent Switcher
> >            - adi,lt7182s
> 
> seems like you removed the wrong comment here? With this, ADP5589 would have
> a comment describing ADP5585.

Oops, my bad. You're absolutely right, thank you for catching this. I
will fix and send a new version.

-- 
Regards,

Laurent Pinchart