lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240610161816.GE20640@redhat.com>
Date: Mon, 10 Jun 2024 18:18:17 +0200
From: Oleg Nesterov <oleg@...hat.com>
To: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Tejun Heo <tj@...nel.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/1] exit: kill signal_struct->quick_threads

On 06/10, Oleg Nesterov wrote:
>
> > At the moment I am staring at wait_task_zombie and trying to understand
> > how:
> >
> > 	status = (p->signal->flags & SIGNAL_GROUP_EXIT)
> > 		? p->signal->group_exit_code : p->exit_code;
> >
> > works without any locks or barriers.
>
> Agreed, at first glance this looks worrying without siglock... I'll try
> to take a look, perhaps we can simply kill the SIGNAL_GROUP_EXIT check,
> not sure.

Still not sure, will check tomorrow, but probably yes. We can rely on the
the exit_state == EXIT_ZOMBIE check in the caller and tasklist_lock.
OTOH, we should probably take ptrace into account...

In short, I am still not sure ;) but I agree this code needs some changes,
the comments at least.

> But this patch should not make any difference ?

Yes.

Oleg.


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ