linux-kernel - Re: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG instead of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <49b57b18-c7ba-4059-ab1d-b337017ea8e4@lunn.ch>
Date: Tue, 11 Jun 2024 17:55:12 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Sean Anderson <sean.anderson@...ux.dev>
Cc: Radhey Shyam Pandey <radhey.shyam.pandey@....com>,
	netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
	linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
	Michal Simek <michal.simek@....com>,
	Paolo Abeni <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
	"David S . Miller" <davem@...emloft.net>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v2] net: xilinx: axienet: Use NL_SET_ERR_MSG
 instead of netdev_err

On Tue, Jun 11, 2024 at 11:41:16AM -0400, Sean Anderson wrote:
> This error message can be triggered by userspace. Use NL_SET_ERR_MSG so
> the message is returned to the user and to avoid polluting the kernel
> logs. Additionally, change the return value from EFAULT to EBUSY to
> better reflect the error (which has nothing to do with addressing).
> 
> Signed-off-by: Sean Anderson <sean.anderson@...ux.dev>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew