linux-kernel - Re: [PATCH net v3] bnxt_en: Adjust logging of firmware messages in case of released token in __hwrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACKFLinkivwuOMgEY74bNWzy2bNLheR7dWsPSmbLdCMhHxDqLQ@mail.gmail.com>
Date: Tue, 11 Jun 2024 09:39:32 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Aleksandr Mishin <amishin@...rgos.ru>
Cc: Edwin Peer <edwin.peer@...adcom.com>, "David S. Miller" <davem@...emloft.net>, 
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lvc-project@...uxtesting.org, Wojciech Drewek <wojciech.drewek@...el.com>
Subject: Re: [PATCH net v3] bnxt_en: Adjust logging of firmware messages in
 case of released token in __hwrm_send()

On Tue, Jun 11, 2024 at 1:28 AM Aleksandr Mishin <amishin@...rgos.ru> wrote:
>
> In case of token is released due to token->state == BNXT_HWRM_DEFERRED,
> released token (set to NULL) is used in log messages. This issue is
> expected to be prevented by HWRM_ERR_CODE_PF_UNAVAILABLE error code. But
> this error code is returned by recent firmware. So some firmware may not
> return it. This may lead to NULL pointer dereference.
> Adjust this issue by adding token pointer check.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Fixes: 8fa4219dba8e ("bnxt_en: add dynamic debug support for HWRM messages")
> Suggested-by: Michael Chan <michael.chan@...adcom.com>
> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@...el.com>
> ---
> v1->v2: Preserve the error message by replacing 'token' with 'ctx->req->seq_id' as suggested by Michael.
>  As the patch didn't change significantly, add Wojciech's Reviewed-by tag from the previous version.
> v2->v3: Fix missing alignment.

Thanks.
Reviewed-by: Michael Chan <michael.chan@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)