linux-kernel - Re: [PATCH] dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 23:58:31 +0530
From: Vinod Koul <vkoul@...nel.org>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Yangtao Li <frank.li@...o.com>, linux-arm-msm@...r.kernel.org, 
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org, 
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom: gpi: clean up the IRQ disable/enable
 in gpi_reset_chan()


On Thu, 09 May 2024 14:02:11 +0300, Dan Carpenter wrote:
> The calls write_lock/unlock_irq() disables and re-enables the IRQs.
> Calling spin_lock_irqsave() and spin_lock_restore() when the IRQs are
> already disabled doesn't do anything and just makes the code confusing.
> 
> 

Applied, thanks!

[1/1] dmaengine: qcom: gpi: clean up the IRQ disable/enable in gpi_reset_chan()
      commit: f8f530ba429a334fe1a28714787f8a98e90777ec

Best regards,
-- 
Vinod Koul <vkoul@...nel.org>