linux-kernel - Re: [PATCH] hostfs: Add const qualifier to host_root in hostfs_fill

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2144113714.220205.1718137142446.JavaMail.zimbra@nod.at>
Date: Tue, 11 Jun 2024 22:19:02 +0200 (CEST)
From: Richard Weinberger <richard@....at>
To: Nathan Chancellor <nathan@...nel.org>
Cc: Christian Brauner <brauner@...nel.org>, Hongbo Li <lihongbo22@...wei.com>, 
	anton ivanov <anton.ivanov@...bridgegreys.com>, 
	Johannes Berg <johannes@...solutions.net>, 
	linux-um <linux-um@...ts.infradead.org>, 
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hostfs: Add const qualifier to host_root in
 hostfs_fill_super()

----- Ursprüngliche Mail -----
> Von: "Nathan Chancellor" <nathan@...nel.org>
> An: "Christian Brauner" <brauner@...nel.org>
> CC: "Hongbo Li" <lihongbo22@...wei.com>, "richard" <richard@....at>, "anton ivanov" <anton.ivanov@...bridgegreys.com>,
> "Johannes Berg" <johannes@...solutions.net>, "linux-um" <linux-um@...ts.infradead.org>, "linux-kernel"
> <linux-kernel@...r.kernel.org>, "Nathan Chancellor" <nathan@...nel.org>
> Gesendet: Dienstag, 11. Juni 2024 21:58:41
> Betreff: [PATCH] hostfs: Add const qualifier to host_root in hostfs_fill_super()

> After the recent conversion to the new mount API, there is a warning
> when building hostfs (which may be upgraded to an error via
> CONFIG_WERROR=y):
> 
>  fs/hostfs/hostfs_kern.c: In function 'hostfs_fill_super':
>  fs/hostfs/hostfs_kern.c:942:27: warning: initialization discards 'const'
>  qualifier from pointer target type [-Wdiscarded-qualifiers]
>    942 |         char *host_root = fc->source;
>        |                           ^~
> 
> Add the 'const' qualifier, as host_root will not be modified after its
> assignment. Move the assignment to keep the existing reverse Christmas
> tree order intact.
> 
> Fixes: cd140ce9f611 ("hostfs: convert hostfs to use the new mount API")
> Signed-off-by: Nathan Chancellor <nathan@...nel.org>

Acked-by: Richard Weinberger <richard@....at>

Thanks,
//richard