linux-kernel - Re: [PATCH next-next] net: phy: realtek: add support for rtl8224 2.5Gbps PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f6f82e0c-5cf5-4a1c-891c-9e772f2403d4@alliedtelesis.co.nz>
Date: Tue, 11 Jun 2024 20:41:39 +0000
From: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To: Andrew Lunn <andrew@...n.ch>
CC: "hkallweit1@...il.com" <hkallweit1@...il.com>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH next-next] net: phy: realtek: add support for rtl8224
 2.5Gbps PHY


On 12/06/24 01:21, Andrew Lunn wrote:
> On Tue, Jun 11, 2024 at 05:34:14PM +1200, Chris Packham wrote:
>> The Realtek RTL8224 PHY is a 2.5Gbps capable PHY. It only uses the
>> clause 45 MDIO interface and can leverage the support that has already
>> been added for the other 822x PHYs.
>>
>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
> You probably should Cc: Eric Woudstra and Marek Behún who have both
> worked on 2.5G variants of this PHY.
>
Hmm get_maintainer.pl didn't pick them up but does with the --git 
option. Did something change with that recently? Or maybe I'm just 
running it wrong. I'll add Cc them on the original patch and include 
them if there is a v2.

>> Notes:
>>      I'm currently testing this on an older kernel because the board I'm
>>      using has a SOC/DSA switch that has a driver in openwrt for Linux 5.15.
>>      I have tried to selectively back port the bits I need from the other
>>      rtl822x work so this should be all that is required for the rtl8224.
>>      
>>      There's quite a lot that would need forward porting get a working system
>>      against a current kernel so hopefully this is small enough that it can
>>      land while I'm trying to figure out how to untangle all the other bits.
>       
> I don't see this as being a problem. It should not be possible to
> cause regressions by adding a new device like this. If it turns out to
> be broken, you can fix it up later.
>
> 	Andrew