linux-kernel - Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 23:24:27 +0200
From: Danilo Krummrich <dakr@...hat.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: daniel@...ll.ch, nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kherbst@...hat.com, lyude@...hat.com
Subject: Re: [PATCH 2/6] drm/nouveau: remove unused struct 'init_exec'

On 6/11/24 12:37, Dr. David Alan Gilbert wrote:
> * Danilo Krummrich (dakr@...hat.com) wrote:
>> On 5/18/24 01:26, linux@...blig.org wrote:
>>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>>
>>> 'init_exec' is unused since
>>> commit cb75d97e9c77 ("drm/nouveau: implement devinit subdev, and new
>>> init table parser")
>>> Remove it.
>>>
>>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>>
>> Acked-by: Danilo Krummrich <dakr@...hat.com>
>>
>> To which series does this patch belong?
> 
> Actually all of them were independent patches on drm
> some of which are all in, so it can be taken by itself.
> 
>> Need me to apply it?
> 
> Yes please!

Applied to drm-misc-fixes, thanks!

> 
> Thanks,
> 
> Dave
> 
>> - Danilo
>>
>>> ---
>>>    drivers/gpu/drm/nouveau/nouveau_bios.c | 5 -----
>>>    1 file changed, 5 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/nouveau/nouveau_bios.c b/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> index 79cfab53f80e..8c3c1f1e01c5 100644
>>> --- a/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> +++ b/drivers/gpu/drm/nouveau/nouveau_bios.c
>>> @@ -43,11 +43,6 @@
>>>    #define BIOSLOG(sip, fmt, arg...) NV_DEBUG(sip->dev, fmt, ##arg)
>>>    #define LOG_OLD_VALUE(x)
>>> -struct init_exec {
>>> -	bool execute;
>>> -	bool repeat;
>>> -};
>>> -
>>>    static bool nv_cksum(const uint8_t *data, unsigned int length)
>>>    {
>>>    	/*
>>