linux-kernel - Re: [PATCH v4 1/4] dt-bindings: power: reset: Convert mode-.* properties to array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 16:23:00 -0700
From: Elliot Berman <quic_eberman@...cinc.com>
To: Rob Herring <robh@...nel.org>
CC: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio
	<konrad.dybcio@...aro.org>,
        Sebastian Reichel <sre@...nel.org>,
        "Krzysztof
 Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley
	<conor+dt@...nel.org>, Vinod Koul <vkoul@...nel.org>,
        Andy Yan
	<andy.yan@...k-chips.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        "Mark
 Rutland" <mark.rutland@....com>,
        Bartosz Golaszewski
	<bartosz.golaszewski@...aro.org>,
        Satya Durga Srinivasu Prabhala
	<quic_satyap@...cinc.com>,
        Melody Olvera <quic_molvera@...cinc.com>,
        Shivendra Pratap <quic_spratap@...cinc.com>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        Florian Fainelli <florian.fainelli@...adcom.com>,
        <linux-pm@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>
Subject: Re: [PATCH v4 1/4] dt-bindings: power: reset: Convert mode-.*
 properties to array

On Tue, Jun 11, 2024 at 02:40:01PM -0600, Rob Herring wrote:
> On Tue, Jun 11, 2024 at 08:35:13AM -0700, Elliot Berman wrote:
> > PSCI reboot mode will map a mode name to multiple magic values instead
> > of just one. Convert the mode-.* property to an array. Users of the
> > reboot-mode schema will need to specify the maxItems of the mode-.*
> > properties. Existing users will all be 1.
> > 
> > Signed-off-by: Elliot Berman <quic_eberman@...cinc.com>
> > ---
> >  .../devicetree/bindings/power/reset/nvmem-reboot-mode.yaml        | 5 +++++
> >  Documentation/devicetree/bindings/power/reset/qcom,pon.yaml       | 8 ++++++++
> >  Documentation/devicetree/bindings/power/reset/reboot-mode.yaml    | 4 ++--
> >  .../devicetree/bindings/power/reset/syscon-reboot-mode.yaml       | 5 +++++
> >  4 files changed, 20 insertions(+), 2 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> > index 627f8a6078c2..9b9bbc0f29e7 100644
> > --- a/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> > +++ b/Documentation/devicetree/bindings/power/reset/nvmem-reboot-mode.yaml
> > @@ -31,6 +31,11 @@ properties:
> >  allOf:
> >    - $ref: reboot-mode.yaml#
> >  
> > +patternProperties:
> > +  "^mode-.*$":
> > +    items:
> > +      maxItems: 1
> 
> Drop 'items'. Otherwise, you are defining constraints of a matrix.
> 

If I do this, I also have to add $ref: .../uint32-array as well so
the property can be picked up as an array type. Let me know if this isn't
right, otherwise I'll send out a fixed version in a few days.

Thanks,
Elliot