[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZmfZukP3a2atzQma@infradead.org>
Date: Mon, 10 Jun 2024 21:59:38 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Mateusz Guzik <mjguzik@...il.com>
Cc: brauner@...nel.org, viro@...iv.linux.org.uk, jack@...e.cz,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-btrfs@...r.kernel.org, josef@...icpanda.com
Subject: Re: [PATCH v2 1/2] vfs: add rcu-based find_inode variants for iget
ops
> +EXPORT_SYMBOL(iget5_locked_rcu);
EXPORT_SYMBOL_GPL for rcu APIs.
> +static void __wait_on_freeing_inode(struct inode *inode, bool locked)
> {
> wait_queue_head_t *wq;
> DEFINE_WAIT_BIT(wait, &inode->i_state, __I_NEW);
> wq = bit_waitqueue(&inode->i_state, __I_NEW);
> prepare_to_wait(wq, &wait.wq_entry, TASK_UNINTERRUPTIBLE);
> spin_unlock(&inode->i_lock);
> - spin_unlock(&inode_hash_lock);
> + rcu_read_unlock();
> + if (locked)
> + spin_unlock(&inode_hash_lock);
The conditional locking here is goign to make sparse rather unhappy.
Please try to find a way to at least annotate it, or maybe find
another way around like, like leaving the schedule in finish_wait
in the callers.
> +extern struct inode *ilookup5_nowait_rcu(struct super_block *sb,
> + unsigned long hashval, int (*test)(struct inode *, void *),
> + void *data);
No need for the extern here (or down below).
Powered by blists - more mailing lists