linux-kernel - Re: [PATCH v2 1/2] vfs: add rcu-based find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGudoHH_Cx1F5Fdiv7EQaz_pWmZUyuieMdx+_XsUXa6AY829Yw@mail.gmail.com>
Date: Tue, 11 Jun 2024 07:36:46 +0200
From: Mateusz Guzik <mjguzik@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: brauner@...nel.org, viro@...iv.linux.org.uk, jack@...e.cz, 
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org, 
	linux-btrfs@...r.kernel.org, josef@...icpanda.com
Subject: Re: [PATCH v2 1/2] vfs: add rcu-based find_inode variants for iget ops

On Tue, Jun 11, 2024 at 7:20 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Tue, Jun 11, 2024 at 07:17:41AM +0200, Mateusz Guzik wrote:
> >
> > I agree, but this is me just copying and modifying an existing line.
> >
> > include/linux/fs.h is chock full of extern-prefixed func declarations,
> > on top of that some name the arguments while the rest does not.
> >
> > Someone(tm) should definitely clean it up, but I'm not interested in
> > bikeshedding about it.
>
> No one asked you to clean the mess up, but don't add any in changed
> or added lines.  Without that:
>
> Nacked-by: Christoph Hellwig <hch@....de>
>

I am not saying you told me to clean the file up.

I am explaining why the addition looks the way it does: I am keeping
it consistent with the surroundings, which I assumed is the preferred
way.

That said, whichever way this is spelled out is fine with me so if vfs
overlords want 'extern' removed I will make the change no problem. (or
based on what I had seen from Christian so far, he will the touch it
up himself, which is again fine with me)

-- 
Mateusz Guzik <mjguzik gmail.com>