linux-kernel - Re: [PATCH 1/5] power: reset: brcmstb: Use normal driver register function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240611060959.nvcaasoft7l2gr3w@dhruva>
Date: Tue, 11 Jun 2024 11:39:59 +0530
From: Dhruva Gole <d-gole@...com>
To: Andrew Davis <afd@...com>
CC: Sebastian Reichel <sre@...nel.org>,
        Florian Fainelli
	<florian.fainelli@...adcom.com>,
        Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>,
        <linux-pm@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/5] power: reset: brcmstb: Use normal driver register
 function

Hi,

On Jun 10, 2024 at 09:28:32 -0500, Andrew Davis wrote:
> The platform_driver_probe() helper is useful when the probe function
> is in the _init section, that is not the case here. Use the normal
> platform_driver_register() function.
> 
> Signed-off-by: Andrew Davis <afd@...com>
> ---
>  drivers/power/reset/brcmstb-reboot.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/power/reset/brcmstb-reboot.c b/drivers/power/reset/brcmstb-reboot.c
> index 0f2944dc93551..797f0079bb590 100644
> --- a/drivers/power/reset/brcmstb-reboot.c
> +++ b/drivers/power/reset/brcmstb-reboot.c
> @@ -140,7 +140,6 @@ static struct platform_driver brcmstb_reboot_driver = {
>  
>  static int __init brcmstb_reboot_init(void)
>  {
> -	return platform_driver_probe(&brcmstb_reboot_driver,
> -					brcmstb_reboot_probe);
> +	return platform_driver_register(&brcmstb_reboot_driver);

Reviewed-by: Dhruva Gole <d-gole@...com>


-- 
Best regards,
Dhruva