linux-kernel - Re: [PATCH 01/14] scsi: fnic: Replace shost_printk with pr_info/pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6b5e96e6-8c57-44ee-a763-3b91791813af@suse.de>
Date: Tue, 11 Jun 2024 08:32:05 +0200
From: Hannes Reinecke <hare@...e.de>
To: Karan Tilak Kumar <kartilak@...co.com>, sebaddel@...co.com
Cc: arulponn@...co.com, djhawar@...co.com, gcboffa@...co.com,
 mkai2@...co.com, satishkh@...co.com, jejb@...ux.ibm.com,
 martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/14] scsi: fnic: Replace shost_printk with
 pr_info/pr_err

On 6/10/24 23:50, Karan Tilak Kumar wrote:
> Sending host information to shost_printk
> prior to host initialization in fnic is unnecessary.
> Replace shost_printk and a printk prior to this
> initialization with pr_info and pr_err accordingly.
> 
Please use 'dev_info' and 'dev_err' instead.
pr_info/pr_err have the problem that they don't reference
the device generating the message, making tracking of
related messages in a large message log problematic.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                  Kernel Storage Architect
hare@...e.de                                +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich