linux-kernel - Re: [PATCH v2] selftests/resctrl: Fix noncont_cat_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32ee6801-cc68-e058-dfca-521ef9f398cb@linux.intel.com>
Date: Tue, 11 Jun 2024 09:50:22 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "Moger, Babu" <babu.moger@....com>
cc: fenghua.yu@...el.com, Reinette Chatre <reinette.chatre@...el.com>, 
    shuah@...nel.org, LKML <linux-kernel@...r.kernel.org>, 
    linux-kselftest@...r.kernel.org, 
    Maciej Wieczór-Retman <maciej.wieczor-retman@...el.com>, 
    peternewman@...gle.com, eranian@...gle.com
Subject: Re: [PATCH v2] selftests/resctrl: Fix noncont_cat_run_test for AMD

On Mon, 10 Jun 2024, Moger, Babu wrote:
> On 6/10/24 11:20, Ilpo Järvinen wrote:
> > On Mon, 10 Jun 2024, Babu Moger wrote:
> > 
> >> The selftest noncont_cat_run_test fails on AMD with the warnings. Reason
> > 
> > noncont_cat_run_test()
> 
> I want to mention the test here. not function. How about this?
> 
> "The selftest non-contiguous CBM test fails on AMD with the warnings."

Yes, it's possible to refer to something with natural language (in fact, I 
personally find that better than using a function name when both options 
exist).

The underscores are C artifacts to replace spaces that do not belong to 
natural language so if one uses underscores, I'll always take it as a 
direct reference to C code.

The quote still has "the warnings" though (but I see Reinette already 
noted that).

> > (In general, use () when refering to a function, same thing in the 
> > shortlog).
> > 
> > "the warnings" sounds like I should know about what warning it fails with
> > but there's no previous context which tells that information. I suggest 
> > you either use "a warning" or quote the warning it fails with into the 
> > commit message.
> > 
> >> is, AMD supports non contiguous CBM masks but does not report it via CPUID.


-- 
 i.