linux-kernel - [PATCH v2] .editorconfig: remove trim_trailing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 09:27:38 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: masahiroy@...nel.org
Cc: linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Danny Lin <danny@...ag0n.dev>,
	Íñigo Huguet <ihuguet@...hat.com>,
	Mickaël Salaün <mic@...ikod.net>,
	Vincent Mailhol <mailhol.vincent@...adoo.fr>
Subject: [PATCH v2] .editorconfig: remove trim_trailing_whitespace option

Some editors (like the vim variants), when seeing "trim_whitespace"
decide to do just that for all of the whitespace in the file you are
saving, even if it is not on a line that you have modified.  This plays
havoc with diffs and is NOT something that should be intended.

As the "only trim whitespace on modified files" is not part of the
editorconfig standard yet, just delete these lines from the
.editorconfig file so that we don't end up with diffs that are
automatically rejected by maintainers for containing things they
shouldn't.

Cc: Danny Lin <danny@...ag0n.dev>
Cc: Íñigo Huguet <ihuguet@...hat.com>
Cc: Mickaël Salaün <mic@...ikod.net>
Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>
Cc: Masahiro Yamada <masahiroy@...nel.org>
Fixes: 5a602de99797 ("Add .editorconfig file for basic formatting")
Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
---
v2: - only remove the lines, don't move the whole file to Documentation
    - add Fixes: tag


 .editorconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/.editorconfig b/.editorconfig
index 854773350cc5..29a30ccfc07b 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -5,7 +5,6 @@ root = true
 [{*.{awk,c,dts,dtsi,dtso,h,mk,s,S},Kconfig,Makefile,Makefile.*}]
 charset = utf-8
 end_of_line = lf
-trim_trailing_whitespace = true
 insert_final_newline = true
 indent_style = tab
 indent_size = 8
@@ -13,7 +12,6 @@ indent_size = 8
 [*.{json,py,rs}]
 charset = utf-8
 end_of_line = lf
-trim_trailing_whitespace = true
 insert_final_newline = true
 indent_style = space
 indent_size = 4
@@ -26,7 +24,6 @@ indent_size = 8
 [*.yaml]
 charset = utf-8
 end_of_line = lf
-trim_trailing_whitespace = unset
 insert_final_newline = true
 indent_style = space
 indent_size = 2
-- 
2.45.2