linux-kernel - Re: [PATCH] atm/fore200e: Consolidate available cell rate update to prevent race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ed41eff-284c-4c44-8090-d2c1765ab6b5@web.de>
Date: Tue, 11 Jun 2024 09:39:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Gui-Dong Han <hanguidong02@...look.com>,
 linux-atm-general@...ts.sourceforge.net, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, Chas Williams <3chas3@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Jia-Ju Bai <baijiaju1990@...il.com>
Subject: Re: [PATCH] atm/fore200e: Consolidate available cell rate update to
 prevent race condition

> In fore200e_change_qos, there is a race condition due to two consecutive
> updates to the 'available_cell_rate' variable. If a read operation
> occurs between these updates, an intermediate value might be read,
> leading to potential bugs.

* Would you like to explain a bit more why you find the applied mutex
  insufficient for data synchronisation aspects?

* Is any special analysis tool (like “BassCheck”) involved in such a contribution?

> To fix this issue, 'available_cell_rate' should be adjusted in a single
> operation, ensuring consistency and preventing any intermediate states
> from being read.

* Please improve the change description with an imperative wording.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.10-rc2#n94

* How do you think about to specify the name of the affected function
  in the summary phrase?

* I would like to point out that similar source code adjustments can be achieved
  also by the means of the semantic patch language (Coccinelle software).

Regards,
Markus