linux-kernel - Re: [PATCH] .editorconfig: move to Documentation/ directory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMZ6RqLtc5jtfjeQO2Su8iSjw4bbPczKMsnW3mCB=SXkSufY-g@mail.gmail.com>
Date: Tue, 11 Jun 2024 16:56:47 +0900
From: Vincent MAILHOL <mailhol.vincent@...adoo.fr>
To: Danny Lin <danny@...ag0n.dev>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, masahiroy@...nel.org, 
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org, 
	Íñigo Huguet <ihuguet@...hat.com>, 
	Mickaël Salaün <mic@...ikod.net>
Subject: Re: [PATCH] .editorconfig: move to Documentation/ directory

On Tue. 11 June 2024 at 15:53, Danny Lin <danny@...ag0n.dev> wrote:
> On Mon, Jun 10, 2024 at 11:49 PM, Greg Kroah-Hartman wrote:
> > Some editors (like the vim variants), when seeing "trim_whitespace"
> > decide to do just that for all of the whitespace in the file you are
> > saving, even if it is not on a line that you have modified.  This plays
> > havoc with diffs and is NOT something that should be intended.
>
> If trim_trailing_whitespace is the only rule that has actually been a problem,
> how about removing it and leaving the rest of .editorconfig intact?
> The other rules are still useful to have as defaults.

+1

The trim_trailling_whitespace can be removed. IMHO the main point of
the .editorconfig is to set up the correct indentation, that is to say
the indent_style and indent_size parameters, and I don't think that
anyone is having issues with these so far.

> Thanks,
> Danny
>
> >
> > As the "only trim whitespace on modified files" is not part of the
> > editorconfig standard, just move the whole thing off to the
> > Documentation/ directory so that those that wish to use such a thing can
> > pick it up from there.
> >
> > Cc: Danny Lin <danny@...ag0n.dev>
> > Cc: Íñigo Huguet <ihuguet@...hat.com>
> > Cc: Mickaël Salaün <mic@...ikod.net>
> > Cc: Vincent Mailhol <mailhol.vincent@...adoo.fr>
> > Cc: Masahiro Yamada <masahiroy@...nel.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> > ---
> >  .editorconfig => Documentation/.editorconfig | 0

This would not solve the issue, because it would still apply for
anything under Documentation/*

> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename .editorconfig => Documentation/.editorconfig (100%)
> >
> > diff --git a/.editorconfig b/Documentation/.editorconfig
> > similarity index 100%
> > rename from .editorconfig
> > rename to Documentation/.editorconfig
> > --
> > 2.45.2