linux-kernel - Re: [PATCH] fpga: altera-fpga2sdram: remove unused struct 'prop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZmgH3FakPP2w/ksI@yilunxu-OptiPlex-7050>
Date: Tue, 11 Jun 2024 16:16:28 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: linux@...blig.org
Cc: mdf@...nel.org, hao.wu@...el.com, linux-fpga@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fpga: altera-fpga2sdram: remove unused struct 'prop_map'

On Thu, May 30, 2024 at 09:52:45PM +0100, linux@...blig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@...blig.org>

This is only needed if the person sending the patch is not the author.

> 
> 'prop_map' has been unused since the original
> commit e5f8efa5c8bf ("ARM: socfpga: fpga bridge driver support").

Please use 'fixes:' tag.

Thanks,
Yilun

> 
> Remove it.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
> ---
>  drivers/fpga/altera-fpga2sdram.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/drivers/fpga/altera-fpga2sdram.c b/drivers/fpga/altera-fpga2sdram.c
> index 6b60ca004345..f4de3fea0b2d 100644
> --- a/drivers/fpga/altera-fpga2sdram.c
> +++ b/drivers/fpga/altera-fpga2sdram.c
> @@ -75,12 +75,6 @@ static int alt_fpga2sdram_enable_set(struct fpga_bridge *bridge, bool enable)
>  	return _alt_fpga2sdram_enable_set(bridge->priv, enable);
>  }
>  
> -struct prop_map {
> -	char *prop_name;
> -	u32 *prop_value;
> -	u32 prop_max;
> -};
> -
>  static const struct fpga_bridge_ops altera_fpga2sdram_br_ops = {
>  	.enable_set = alt_fpga2sdram_enable_set,
>  	.enable_show = alt_fpga2sdram_enable_show,
> -- 
> 2.45.1
> 
>