| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Jun 2024 13:25:11 +0300 From: Viacheslav <adeep@...ina.in> To: Conor Dooley <conor@...nel.org> Cc: Neil Armstrong <neil.armstrong@...aro.org>, Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, Martin Blumenstingl <martin.blumenstingl@...glemail.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-amlogic@...ts.infradead.org, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org Subject: Re: [PATCH v5 3/4] dt-bindings: arm: amlogic: amlogic,meson-gx-ao-secure: add secure-monitor property Hi! 10/06/2024 19.08, Conor Dooley wrote: > On Mon, Jun 10, 2024 at 11:39:49AM +0300, Viacheslav Bocharov wrote: >> Add secure-monitor property to schema for meson-gx-socinfo-sm driver. > > "bindings are for hardware, not drivers". Why purpose does the "secure > monitor" serve that the secure firmware needs a reference to it? This driver is an extension to the meson-gx-socinfo driver: it supplements information obtained from the register with information from the SM_GET_CHIP_ID secure monitor call. Due to the specifics of the module loading order, we cannot do away with meson-gx-socinfo, as it is used for platform identification in some drivers. Therefore, the extended information is formatted as a separate driver, which is loaded after the secure-monitor driver. The ability to obtain additional information depends on the support for the call in the secure-monitor, which can be described by an additional link from the amlogic,meson-gx-ao-secure node to the secure-monitor node, similar to how it is done for amlogic,meson-gxbb-efuse. > > Thanks, > Conor. > >> >> Signed-off-by: Viacheslav Bocharov <adeep@...ina.in> >> --- >> .../bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml >> index 7dff32f373cb..1128a794ec89 100644 >> --- a/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml >> +++ b/Documentation/devicetree/bindings/arm/amlogic/amlogic,meson-gx-ao-secure.yaml >> @@ -32,6 +32,10 @@ properties: >> reg: >> maxItems: 1 >> >> + secure-monitor: > > Missing a vendor prefix. > >> + description: phandle to the secure-monitor node >> + $ref: /schemas/types.yaml#/definitions/phandle >> + >> amlogic,has-chip-id: >> description: | >> A firmware register encodes the SoC type, package and revision >> -- >> 2.45.2 >> >> >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@...ts.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic -- with regards, Viacheslav
Powered by blists - more mailing lists