linux-kernel - Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024061118-sycamore-leggings-05a9@gregkh>
Date: Tue, 11 Jun 2024 13:11:28 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Jacky Huang <ychuang570808@...il.com>
Cc: dan.carpenter@...aro.org, jirislaby@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Jacky Huang <ychuang3@...oton.com>
Subject: Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of_node

On Tue, Jun 11, 2024 at 09:22:51AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@...oton.com>
> 
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
> 
> Signed-off-by: Jacky Huang <ychuang3@...oton.com>
> ---
>  drivers/tty/serial/ma35d1_serial.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c
> index 19f0a305cc43..3b4206e815fe 100644
> --- a/drivers/tty/serial/ma35d1_serial.c
> +++ b/drivers/tty/serial/ma35d1_serial.c
> @@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev)
>  	struct uart_ma35d1_port *up;
>  	int ret = 0;
>  
> -	if (pdev->dev.of_node) {
> -		ret = of_alias_get_id(pdev->dev.of_node, "serial");
> -		if (ret < 0) {
> -			dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> -			return ret;
> -		}
> +	if (!pdev->dev.of_node)
> +		return -ENODEV;
> +
> +	ret = of_alias_get_id(pdev->dev.of_node, "serial");
> +	if (ret < 0) {
> +		dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret);
> +		return ret;
>  	}
>  	up = &ma35d1serial_ports[ret];
>  	up->port.line = ret;

What commit id does this fix?

thanks,

greg k-h