linux-kernel - Re: [PATCH 3/3] media: vgxy61: Add MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 13:57:24 +0200
From: Benjamin Mugnier <benjamin.mugnier@...s.st.com>
To: Sakari Ailus <sakari.ailus@...ux.intel.com>
CC: Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Sylvain Petinot <sylvain.petinot@...s.st.com>,
        Laurent Pinchart
	<laurent.pinchart@...asonboard.com>,
        <linux-media@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] media: vgxy61: Add MODULE_ALIAS()

Hi Sakari,

On 6/11/24 10:21, Sakari Ailus wrote:
> Hi Benjamin,
> 
> On Mon, Jun 10, 2024 at 05:08:15PM +0200, Benjamin Mugnier wrote:
>> Preserve user space retro compatibility after the device rename.
>>
>> Signed-off-by: Benjamin Mugnier <benjamin.mugnier@...s.st.com>
>> ---
>>  drivers/media/i2c/vgxy61.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/media/i2c/vgxy61.c b/drivers/media/i2c/vgxy61.c
>> index ca3b43608dad..c85f356946ca 100644
>> --- a/drivers/media/i2c/vgxy61.c
>> +++ b/drivers/media/i2c/vgxy61.c
>> @@ -1898,3 +1898,4 @@ MODULE_AUTHOR("Mickael Guene <mickael.guene@...com>");
>>  MODULE_AUTHOR("Sylvain Petinot <sylvain.petinot@...s.st.com>");
>>  MODULE_DESCRIPTION("VGXY61 camera subdev driver");
>>  MODULE_LICENSE("GPL");
>> +MODULE_ALIAS("platform:st-vgxy61");
> 
> Perhaps just "st-vgxy61" so that the module still loads if someone loads it
> explicitly? That's what you'd want, right, as the old compatible string
> will remain?
> 

Yes it is for explicit loading. I'll remove the "platform" prefix.

But maybe I'm overthinking and I could just remove the MODULE_ALIAS()
completely from this series. What do you think ?

-- 
Regards,

Benjamin