linux-kernel - Re: [PATCH v3 4/6] crypto: ti - add driver for MCRC64 engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32303d99-c5ba-4fec-8981-9b9966dc3291@web.de>
Date: Tue, 11 Jun 2024 14:02:52 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Kamlesh Gurudasani <kamlesh@...com>, devicetree@...r.kernel.org,
 linux-crypto@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-stm32@...md-mailman.stormreply.com,
 Herbert Xu <herbert@...dor.apana.org.au>, Tero Kristo <kristo@...nel.org>,
 Will Deacon <will@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Catalin Marinas <catalin.marinas@....com>, Conor Dooley
 <conor+dt@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>, Rob Herring <robh@...nel.org>,
 Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH v3 4/6] crypto: ti - add driver for MCRC64 engine

…
> +++ b/drivers/crypto/ti/mcrc64.c
…
> +static int mcrc64_probe(struct platform_device *pdev)
> +{
…
> +	platform_set_drvdata(pdev, dev_data);
> +
> +	spin_lock(&mcrc64_dev_list.lock);
> +	list_add(&dev_data->list, &mcrc64_dev_list.dev_list);
> +	spin_unlock(&mcrc64_dev_list.lock);
> +
> +	mutex_lock(&refcnt_lock);
> +	if (!refcnt) {
> +		ret = crypto_register_shashes(algs, ARRAY_SIZE(algs));
…
> +	}
> +	refcnt++;
> +	mutex_unlock(&refcnt_lock);
…

Would you become interested to apply lock guards?
https://elixir.bootlin.com/linux/v6.10-rc2/source/include/linux/cleanup.h#L124

Regards,
Markus