linux-kernel - Re: Re: [PATCH v2 1/2] ALSA: dmaengine: Synchronize dma channel in prepare()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e55jugzdtzgiqvvmvtgyp3rovthvl3ky2o4quuxvswt3w5nshr@stuqxwmbpnpo>
Date: Tue, 11 Jun 2024 18:05:30 +0530
From: Jai Luthra <j-luthra@...com>
To: Mark Brown <broonie@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>
CC: Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Liam
 Girdwood <lgirdwood@...il.com>,
        Peter Ujfalusi <peter.ujfalusi@...il.com>,
        <linux-sound@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <alsa-devel@...a-project.org>, Devarsh Thakkar <devarsht@...com>,
        Vignesh
 Raghavendra <vigneshr@...com>,
        Jayesh Choudhary <j-choudhary@...com>
Subject: Re: Re: [PATCH v2 1/2] ALSA: dmaengine: Synchronize dma channel in
 prepare()

Hi Lars, Mark,

On Jun 11, 2024 at 11:39:12 +0100, Mark Brown wrote:
> On Mon, Jun 10, 2024 at 05:45:52PM -0700, Lars-Peter Clausen wrote:
> > On 6/10/24 03:56, Jai Luthra wrote:
> 
> > > Sometimes the stream may be stopped due to XRUN events, in which case
> > > the userspace can call snd_pcm_drop() and snd_pcm_prepare() to stop and
> > > start the stream again.
> 
> > > In these cases, we must wait for the DMA channel to synchronize before
> > > marking the stream as prepared for playback, as the DMA channel gets
> > > stopped by snd_pcm_drop() without any synchronization.
> 
> > We should really implement the sync_stop() PCM callback and let the ALSA
> > core let care of the sync.
> 
> Good point, that's a better idea.

Thanks for the suggestion, sending a v3 with the change.

Peter,
I've kept your R-by intact as it is a minor change.


-- 
Thanks,
Jai

GPG Fingerprint: 4DE0 D818 E5D5 75E8 D45A AFC5 43DE 91F9 249A 7145

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)