linux-kernel - Re: iwlwifi: Regression after migrating to 6.6.32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 11 Jun 2024 14:52:56 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Fabio Estevam <festevam@...il.com>, miriam.rachel.korenblit@...el.com, 
	kvalo@...nel.org
Cc: Jakub Kicinski <kuba@...nel.org>, linux-wireless
 <linux-wireless@...r.kernel.org>, linux-kernel
 <linux-kernel@...r.kernel.org>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32

On Tue, 2024-06-11 at 08:46 -0300, Fabio Estevam wrote:
> 
> [    6.995391] ------------[ cut here ]------------
> [    7.373564] WARNING: CPU: 3 PID: 136 at
> /drivers/net/wireless/intel/iwlwifi/pcie/rx.c:269
> iwl_pcie_rxmq_restock+0x158/0x178 [iwlwifi]
> 

This warning happens if DMA mapping/allocation returns a page that's not
page-aligned??

                rxb->page_dma =
                        dma_map_page(trans->dev, page, rxb->offset,
                                     trans_pcie->rx_buf_bytes,
                                     DMA_FROM_DEVICE);

(or similar places), where rxb->offset will always be 0 unless
rx_buf_bytes is set to 2048, but that can only happen if the amsdu_size
module parameter is set to 4 (=2k) but that's not even supported any
more?

Maybe make this WARN_ONCE(...) with a string that has more info on the
addresses.

johannes