linux-kernel - Re: [PATCH 5/5] kunit: Merge assertion test into kunit-test.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37fcb821-e49f-4f9e-a1d2-1d18d40ea61c@gmail.com>
Date: Tue, 11 Jun 2024 14:10:04 +0100
From: Ivan Orlov <ivan.orlov0322@...il.com>
To: David Gow <davidgow@...gle.com>
Cc: brendan.higgins@...ux.dev, rmoar@...gle.com,
 linux-kselftest@...r.kernel.org, kunit-dev@...glegroups.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 5/5] kunit: Merge assertion test into kunit-test.c

On 6/8/24 10:20, David Gow wrote:
> On Tue, 4 Jun 2024 at 20:32, Ivan Orlov <ivan.orlov0322@...il.com> wrote:
>>
>> Since assert_test covers the part of the KUnit core (the assertion
>> formatting functions), I believe it would be better to have it merged
>> into kunit-test (as it is done for other tests for the KUnit core).
>>
>> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
>> ---
> 
> Personally, I don't mind if the assert tests are in a separate file,
> but do think it's worth having them in the same module.
> 
> Do you think it'd be better to keep them as separate source files (but
> put them in the same module via the Makefile), or is having a single
> source file cleaner?
> 
> Either way, I think this should be merged with the previous patch (see
> my comments there.)
> 

Hi David,

Thank you for the review and sorry for the late reply.

I believe having the assert test in the same file as other kunit core 
tests would be more consistent with the existing test structure 
(otherwise, the tests for other parts of the kunit core should be 
extracted to separate files as well).

What do you think is more appropriate?

-- 
Kind regards,
Ivan Orlov