linux-kernel - Re: iwlwifi: Regression after migrating to 6.6.32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <95163ee547da95964c16f87a38d3326ae4da3253.camel@sipsolutions.net>
Date: Tue, 11 Jun 2024 15:54:16 +0200
From: Johannes Berg <johannes@...solutions.net>
To: Fabio Estevam <festevam@...il.com>
Cc: miriam.rachel.korenblit@...el.com, kvalo@...nel.org, Jakub Kicinski
	 <kuba@...nel.org>, linux-wireless <linux-wireless@...r.kernel.org>, 
 linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32

Hi Fabio,

> 
> I did as suggested:
> 
> --- a/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> +++ b/drivers/net/wireless/intel/iwlwifi/pcie/rx.c
> @@ -266,7 +266,8 @@ static void iwl_pcie_rxmq_restock(struct iwl_trans *trans,
>                 list_del(&rxb->list);
>                 rxb->invalid = false;
>                 /* some low bits are expected to be unset (depending on hw) */
> -               WARN_ON(rxb->page_dma & trans_pcie->supported_dma_mask);
> +               WARN_ONCE(rxb->page_dma & trans_pcie->supported_dma_mask,
> +                         "rxb->offset is %d trans_pcie->rx_buf_bytes
> is %d\n", rxb->offset, trans_pcie->rx_buf_bytes);
> 

> [    5.038174] rxb->offset is 0 trans_pcie->rx_buf_bytes is 4096

so that looks pretty normal?

Might be useful to see rx->page_dma too, supported_dma_mask should be
4095 or 2047 depending on the device, but I'm not sure how you could end
up with a DMA mapping for a page that's not at least 11 bit aligned?

johannes