linux-kernel - Re: [PATCH v2 md-6.11 00/12] md: refacotor and some fixes related to sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12441f87-6e61-4618-a2f5-a2b2b202b26e@molgen.mpg.de>
Date: Tue, 11 Jun 2024 16:10:32 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: agk@...hat.com, snitzer@...nel.org, mpatocka@...hat.com, song@...nel.org,
 xni@...hat.com, mariusz.tkaczyk@...ux.intel.com, dm-devel@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
 yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2 md-6.11 00/12] md: refacotor and some fixes related to
 sync_thread

Dear Yu,


Thank you for your series.


Am 11.06.24 um 15:22 schrieb Yu Kuai:
> From: Yu Kuai <yukuai3@...wei.com>

It’d be great if you wrote a small summary, what the same fixes are, are 
what patches are that.

Nit: Small typo in the summary/title: refacotor → refactor.

> Changes from v1:
>   - respin on the top of md-6.11 branch
> 
> Changes from RFC:
>   - fix some typos;
>   - add patch 7 to prevent some mdadm tests failure;
>   - add patch 12 to fix BUG_ON() panic by mdadm test 07revert-grow;
> 
> Yu Kuai (12):
>    md: rearrange recovery_flags
>    md: add a new enum type sync_action
>    md: add new helpers for sync_action
>    md: factor out helper to start reshape from action_store()
>    md: replace sysfs api sync_action with new helpers
>    md: remove parameter check_seq for stop_sync_thread()
>    md: don't fail action_store() if sync_thread is not registered
>    md: use new helers in md_do_sync()

hel*p*ers

>    md: replace last_sync_action with new enum type
>    md: factor out helpers for different sync_action in md_do_sync()
>    md: pass in max_sectors for pers->sync_request()
>    md/raid5: avoid BUG_ON() while continue reshape after reassembling
> 
>   drivers/md/dm-raid.c |   2 +-
>   drivers/md/md.c      | 437 ++++++++++++++++++++++++++-----------------
>   drivers/md/md.h      | 124 +++++++++---
>   drivers/md/raid1.c   |   5 +-
>   drivers/md/raid10.c  |   8 +-
>   drivers/md/raid5.c   |  23 ++-
>   6 files changed, 388 insertions(+), 211 deletions(-)


Kind regards,

Paul