linux-kernel - Re: [PATCH v2] dt-bindings: sound: Convert max98088 to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5357897-9bb3-4297-843d-c97dadc3de4b@kernel.org>
Date: Wed, 12 Jun 2024 17:04:41 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>, robh@...nel.org,
 krzk+dt@...nel.org, conor+dt@...nel.org, lgirdwood@...il.com,
 broonie@...nel.org
Cc: skhan@...uxfoundation.org, javier.carrasco.cruz@...il.com,
 linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: sound: Convert max98088 to dtschema

On 12/06/2024 16:59, Abdulrasaq Lawani wrote:
> Convert the max98088 audio codec txt bindings to DT schema.
> 
> Signed-off-by: Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
> ---
> Validated with dtschema and tested against samsung/exynos5800-peach-pi.dts.

What?

This is not a codec for this board. You are mixing now
Documentation/devicetree/bindings/sound/maxim,max98090.yaml

Whatever you validated against Peach Pi DTS is wrong or not enough. You
need to validate it against DTS using this binding.


> +
> +maintainers:
> +  - Abdulrasaq Lawani <abdulrasaqolawani@...il.com>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - maxim,max98088
> +      - maxim,max98091

91? You meant 89...

Best regards,
Krzysztof