linux-kernel - Re: [PATCH] nvmet: always initialize cqe.result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZmnhMkqt7xch_4e-@kbusch-mbp.dhcp.thefacebook.com>
Date: Wed, 12 Jun 2024 11:56:02 -0600
From: Keith Busch <kbusch@...nel.org>
To: Daniel Wagner <dwagner@...e.de>
Cc: Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
	Hannes Reinecke <hare@...e.de>, linux-nvme@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvmet: always initialize cqe.result

On Wed, Jun 12, 2024 at 04:11:59PM +0200, Daniel Wagner wrote:
> The spec doesn't mandate that the first two double words (aka results)
> for the command queue entry need to be set to 0 when they are not
> used (not specified). Though, the target implemention returns 0 for TCP
> and FC but not for RDMA.
> 
> Let's make RDMA behave the same and thus explicitly initializing the
> result field. This prevents leaking any data from the stack.

Thanks, applied to nvme-6.10.