linux-kernel - Re: [PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240612180902.GA3178463-robh@kernel.org>
Date: Wed, 12 Jun 2024 12:09:02 -0600
From: Rob Herring <robh@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Daniel Baluta <daniel.baluta@....com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Hugo Villeneuve <hvilleneuve@...onoff.com>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: serial: nxp,sc16is7xx: Add missing child
 node

On Wed, Jun 12, 2024 at 10:24:55PM +0530, Animesh Agarwal wrote:
> Add missing child node property clock-sc16is7xx to nxp,sc16is7xx.yaml. This
> fixes the following warning upon running make dtbs_check:
> 
> ./arch/arm64/boot/dts/freescale/fsl-ls1012a-frdm.dtb: serial@0:
> Unevaluated properties are not allowed ('clock-sc16is7xx' was unexpected)
> from schema $id: http://devicetree.org/schemas/serial/nxp,sc16is7xx.yaml#

That's a pretty odd case. Lots of devices can a crystal and this is not 
how we describe it. I think the clock node should just be moved out of 
this node to the top level to fix this.

Ideally, when the schema was converted, the warnings from it were looked 
at and were either fixed in the schema on conversion (with notes in 
commit msg) or the warnings were left as to be fixed in the .dts files. 

BTW, dtbs_check is run on every schema patch for the schema in the 
patch. Results are here[1].

Rob

[1] https://patchwork.ozlabs.org/project/devicetree-bindings/list/