[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240612183051.GE4966@unreal>
Date: Wed, 12 Jun 2024 21:30:51 +0300
From: Leon Romanovsky <leon@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Shradha Gupta <shradhagupta@...ux.microsoft.com>,
linux-hardening@...r.kernel.org, netdev@...r.kernel.org,
linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-rdma@...r.kernel.org, Colin Ian King <colin.i.king@...il.com>,
Ahmed Zaki <ahmed.zaki@...el.com>,
Pavan Chebbi <pavan.chebbi@...adcom.com>,
Souradeep Chakrabarti <schakrabarti@...ux.microsoft.com>,
Konstantin Taranov <kotaranov@...rosoft.com>,
Kees Cook <keescook@...omium.org>, Paolo Abeni <pabeni@...hat.com>,
Jakub Kicinski <kuba@...nel.org>,
Eric Dumazet <edumazet@...gle.com>,
"David S. Miller" <davem@...emloft.net>,
Dexuan Cui <decui@...rosoft.com>, Wei Liu <wei.liu@...nel.org>,
Haiyang Zhang <haiyangz@...rosoft.com>,
"K. Y. Srinivasan" <kys@...rosoft.com>,
Jason Gunthorpe <jgg@...pe.ca>, Long Li <longli@...rosoft.com>,
Shradha Gupta <shradhagupta@...rosoft.com>
Subject: Re: [PATCH net-next v4] net: mana: Allow variable size indirection
table
On Mon, Jun 10, 2024 at 03:28:39AM -0700, Shradha Gupta wrote:
> Allow variable size indirection table allocation in MANA instead
> of using a constant value MANA_INDIRECT_TABLE_SIZE.
> The size is now derived from the MANA_QUERY_VPORT_CONFIG and the
> indirection table is allocated dynamically.
>
> Signed-off-by: Shradha Gupta <shradhagupta@...ux.microsoft.com>
> Reviewed-by: Dexuan Cui <decui@...rosoft.com>
> Reviewed-by: Haiyang Zhang <haiyangz@...rosoft.com>
> ---
> Changes in v4:
> * Skip NULLify after free
> * Log proper errors in mana_probe() if mana_attach(), mana_probe_port()
> fails
> * Implement mana_cleanup_indir_table() to avoid code duplication.
>
> Changes in v3:
> * Fixed the memory leak(save_table) in mana_set_rxfh()
>
> Changes in v2:
> * Rebased to latest net-next tree
> * Rearranged cleanup code in mana_probe_port to avoid extra operations
> ---
> drivers/infiniband/hw/mana/qp.c | 10 +--
> drivers/net/ethernet/microsoft/mana/mana_en.c | 85 ++++++++++++++++---
> .../ethernet/microsoft/mana/mana_ethtool.c | 27 ++++--
> include/net/mana/gdma.h | 4 +-
> include/net/mana/mana.h | 9 +-
> 5 files changed, 104 insertions(+), 31 deletions(-)
Hi Jakub,
Like we talked, I created new shared branch for this patch:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/log/?h=mana-shared
Because it took time, the base of this branch is v6.10-rc3 as I'm eager
to get the commit c9d52fb313d3 ("PCI: Revert the cfg_access_lock lockdep mechanism")
from Linus's master, and this shared patch gives me the reason to pull
the fix.
I see that your net-next didn't get -rc3 tag yet, so please pull it after you
advance net-next. After that I'll do the same in RDMA tree.
Thanks
Powered by blists - more mailing lists