Date: Wed, 12 Jun 2024 12:41:53 -0700
From: Wesley Cheng <quic_wcheng@...cinc.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Amadeusz Sławiński
	<amadeuszx.slawinski@...ux.intel.com>,
        <srinivas.kandagatla@...aro.org>, <mathias.nyman@...el.com>,
        <perex@...ex.cz>, <conor+dt@...nel.org>, <corbet@....net>,
        <broonie@...nel.org>, <lgirdwood@...il.com>, <krzk+dt@...nel.org>,
        <Thinh.Nguyen@...opsys.com>, <bgoswami@...cinc.com>, <tiwai@...e.com>,
        <robh@...nel.org>, <gregkh@...uxfoundation.org>
CC: <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>,
        <linux-sound@...r.kernel.org>, <linux-usb@...r.kernel.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-doc@...r.kernel.org>,
        <alsa-devel@...a-project.org>
Subject: Re: [PATCH v23 00/32] Introduce QC USB SND audio offloading support

Hi Pierre,

On 6/12/2024 7:59 AM, Pierre-Louis Bossart wrote:
> 
> 
> On 6/12/24 16:50, Amadeusz Sławiński wrote:
>> On 6/11/2024 1:57 AM, Wesley Cheng wrote:
>>
>>> Wesley Cheng (32):
>>>     ASoC: Add SOC USB APIs for adding an USB backend
>>>     ASoC: dt-bindings: qcom,q6dsp-lpass-ports: Add USB_RX port
>>>     ASoC: qcom: qdsp6: Introduce USB AFE port to q6dsp
>>>     ASoC: qdsp6: q6afe: Increase APR timeout
>>>     ASoC: qcom: qdsp6: Add USB backend ASoC driver for Q6
>>>     ALSA: usb-audio: Introduce USB SND platform op callbacks
>>>     ALSA: usb-audio: Export USB SND APIs for modules
>>>     ALSA: usb-audio: Save UAC sample size information
>>>     usb: dwc3: Specify maximum number of XHCI interrupters
>>>     usb: host: xhci-plat: Set XHCI max interrupters if property is present
>>>     ALSA: usb-audio: qcom: Add USB QMI definitions
>>>     ALSA: usb-audio: qcom: Introduce QC USB SND offloading support
>>>     ALSA: usb-audio: Check for support for requested audio format
>>>     ASoC: usb: Add PCM format check API for USB backend
>>>     ASoC: qcom: qdsp6: Ensure PCM format is supported by USB audio device
>>>     ALSA: usb-audio: Prevent starting of audio stream if in use
>>>     ALSA: usb-audio: Do not allow USB offload path if PCM device is in use
>>>     ASoC: dt-bindings: Update example for enabling USB offload on SM8250
>>>     ALSA: usb-audio: qcom: Populate PCM and USB chip information
>>>     ASoC: qcom: qdsp6: Add support to track available USB PCM devices
>>>     ASoC: Introduce SND kcontrols to select sound card and PCM device
>>>     ASoC: qcom: qdsp6: Add SOC USB offload select get/put callbacks
>>>     ASoC: Introduce SND kcontrols to track USB offloading state
>>>     ASoC: qcom: qdsp6: Add PCM ops to track current state
>>>     ASoC: usb: Create SOC USB SND jack kcontrol
>>>     ASoC: qcom: qdsp6: Add headphone jack for offload connection status
>>>     ASoC: usb: Fetch ASoC sound card information
>>>     ALSA: usb-audio: Add USB offloading capable kcontrol
>>>     ALSA: usb-audio: Allow for rediscovery of connected USB SND devices
>>>     ALSA: usb-audio: qcom: Use card and PCM index from QMI request
>>>     ASoC: usb: Rediscover USB SND devices on USB port add
>>>     ASoC: doc: Add documentation for SOC USB
>>
>> I'm not sure how other reviewers feel about this, but is there any
>> chance to group patches in some logical order? It is bit hard to review
>> when I need to jump from generic ALSA to ASoC then QCOM code and then
>> there are dt-bindings mixed in between and back again.
> 
> Completely agree. And splitting the 32 patches in smaller sets would
> help as well, every time I want to review I just don't have the time to
> go through 32 heavy-duty patches across USB/ALSA/ASoC.

Will try my best, but I've already attempted to compartmentalize 
everything as how it is.  Will try to first re-organize the patches 
based on what Amadeusz recommended and see if that helps.

Thanks
Wesley Cheng

Powered by blists - more mailing lists