linux-kernel - Re: [PATCH] fixmap: Remove unused set_fixmap_offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7f258a4c-6048-4718-851d-4768789bc5e1@app.fastmail.com>
Date: Wed, 12 Jun 2024 22:02:50 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Steven Price" <steven.price@....com>
Cc: Linux-Arch <linux-arch@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fixmap: Remove unused set_fixmap_offset_io()

On Wed, Jun 12, 2024, at 18:00, Steven Price wrote:
> The macro set_fixmap_offset_io() was added in commit f774b7d10e21
> ("arm64: fixmap: fix missing sub-page offset for earlyprintk") but then
> commit 8ef0ed95ee04 ("arm64: remove arch specific earlyprintk") removed
> the file causing the only user to be removed when the two commits were
> merged. Since this has never been used again since the v3.15 release
> remove it.
>
> Signed-off-by: Steven Price <steven.price@....com>
> ---
> This came up because for Arm CCA there is a need to override
> set_fixmap_io() [1] and rather than also update set_fixmap_offset_io() I
> thought it would be better to just drop the unused macro.
>
> [1] https://lore.kernel.org/lkml/20240605093006.145492-6-steven.price@arm.com/

I assume you want to keep this with your other patch, so

Acked-by: Arnd Bergmann <arnd@...db.de>