linux-kernel - Re: [PATCH] nvdimm: make nd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <666a10986e8e4_20324e2946b@iweiny-mobl.notmuch>
Date: Wed, 12 Jun 2024 16:18:16 -0500
From: Ira Weiny <ira.weiny@...el.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Dan Williams
	<dan.j.williams@...el.com>
CC: <nvdimm@...ts.linux.dev>, <linux-kernel@...r.kernel.org>, Vishal Verma
	<vishal.l.verma@...el.com>, Dave Jiang <dave.jiang@...el.com>, Ira Weiny
	<ira.weiny@...el.com>
Subject: Re: [PATCH] nvdimm: make nd_class constant

Greg Kroah-Hartman wrote:
> On Mon, Jun 10, 2024 at 10:44:42AM -0700, Dan Williams wrote:
> > Greg Kroah-Hartman wrote:
> > > Now that the driver core allows for struct class to be in read-only
> > > memory, we should make all 'class' structures declared at build time
> > > placing them into read-only memory, instead of having to be dynamically
> > > allocated at runtime.
> > 
> > Change looks good to me,
> > 
> > Reviewed-by: Dan Williams <dan.j.williams@...el.com>
> > 
> > ...changelog grammar tripped me up though, how about:
> > 
> > "Now that the driver core allows for struct class to be in read-only
> > memory, it is possible to make all 'class' structures be declared at
> > build time. Move the class to a 'static const' declaration and register
> > it rather than dynamically create it."
> 
> That works too, want me to resubmit with this, or can I update it when I
> commit it to my tree?

In that case.

Reviewed-by: Ira Weiny <ira.weiny@...el.com>

> 
> thanks,
> 
> greg "the changelog is the hardest part" k-h