linux-kernel - Re: [PATCH v2] docs: crypto: async-tx-api: fix broken code example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87cyolon4f.fsf@trenco.lwn.net>
Date: Wed, 12 Jun 2024 15:41:04 -0600
From: Jonathan Corbet <corbet@....net>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>, Dan Williams
 <dan.j.williams@...el.com>, Herbert Xu <herbert@...dor.apana.org.au>,
 "David S. Miller" <davem@...emloft.net>, Andre Noll <maan@...temlinux.org>
Cc: linux-crypto@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, kernel@...gutronix.de, Ahmad Fatoum
 <a.fatoum@...gutronix.de>
Subject: Re: [PATCH v2] docs: crypto: async-tx-api: fix broken code example

Ahmad Fatoum <a.fatoum@...gutronix.de> writes:

> The code example fails to compile:
>
>   1) addr_conv is defined twice, once as a VLA, which have been phased out
>
>   2) submit is not a pointer, but is still dereferenced with ->
>
>   3) The first call to async_xor() lacked the trailing semicolon
>
> Fix these issues and while at it, fix some code style nitpicks as well:
>
>   1) make the functions static as users are unlikely to export them
>
>   2) include the relevant header
>
>   3) Shorten the example a bit by removing a redundant variable
>      definition
>
> Fixes: 04ce9ab385dc ("async_xor: permit callers to pass in a 'dma/page scribble' region")
> Signed-off-by: Ahmad Fatoum <a.fatoum@...gutronix.de>

It looks like nobody has picked this up, so I've applied it.

Thanks,

jon