linux-kernel - Re: [PATCH] KVM: interrupt kvm_gmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 12 Jun 2024 16:13:29 -0700
From: Isaku Yamahata <isaku.yamahata@...el.com>
To: Paolo Bonzini <pbonzini@...hat.com>
Cc: linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	Isaku Yamahata <isaku.yamahata@...el.com>,
	Michael Roth <michael.roth@....com>, isaku.yamahata@...ux.intel.com
Subject: Re: [PATCH] KVM: interrupt kvm_gmem_populate() on signals

On Tue, Jun 11, 2024 at 06:22:43AM -0400,
Paolo Bonzini <pbonzini@...hat.com> wrote:

> kvm_gmem_populate() is a potentially lengthy operation that can involve
> multiple calls to the firmware.  Interrupt it if a signal arrives.

What about cond_resched() in the loop?  kvm_gmem_allocate() has both.

The change itself looks good for TDX because KVM_TDX_INIT_MEMREGION checks the
signal.  I can drop the duplicated check.  Similar to cond_resched().
-- 
Isaku Yamahata <isaku.yamahata@...el.com>