[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <813a0c3b-f923-463d-b502-3897d5213180@quicinc.com>
Date: Tue, 11 Jun 2024 21:55:53 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Ira Weiny <ira.weiny@...el.com>, <nvdimm@...ts.linux.dev>
CC: Dan Williams <dan.j.williams@...el.com>,
Vishal Verma
<vishal.l.verma@...el.com>,
Dave Jiang <dave.jiang@...el.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] testing: nvdimm: Add MODULE_DESCRIPTION() macros
On 6/11/2024 9:47 PM, Ira Weiny wrote:
> When building with W=1 the following errors are seen:
>
> WARNING: modpost: missing MODULE_DESCRIPTION() in tools/testing/nvdimm/test/nfit_test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in tools/testing/nvdimm/test/ndtest.o
>
> Add the required MODULE_DESCRIPTION() to the test platform device
> drivers.
>
> Suggested-by: Jeff Johnson <quic_jjohnson@...cinc.com>
> Signed-off-by: Ira Weiny <ira.weiny@...el.com>
> ---
> Jeff I'm not seeing a patch to cover these cases for the missing module
> descriptions you have been sending out. If you have an outstanding
> patch I missed could you point me to it? Otherwise I believe this
> cleans up the nvdimm tree.
> ---
> tools/testing/nvdimm/test/ndtest.c | 1 +
> tools/testing/nvdimm/test/nfit.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/tools/testing/nvdimm/test/ndtest.c b/tools/testing/nvdimm/test/ndtest.c
> index b438f3d053ee..892e990c034a 100644
> --- a/tools/testing/nvdimm/test/ndtest.c
> +++ b/tools/testing/nvdimm/test/ndtest.c
> @@ -987,5 +987,6 @@ static __exit void ndtest_exit(void)
>
> module_init(ndtest_init);
> module_exit(ndtest_exit);
> +MODULE_DESCRIPTION("Test non-NFIT devices");
> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("IBM Corporation");
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index a61df347a33d..cfd4378e2129 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -3382,5 +3382,6 @@ static __exit void nfit_test_exit(void)
>
> module_init(nfit_test_init);
> module_exit(nfit_test_exit);
> +MODULE_DESCRIPTION("Test ACPI NFIT devices");
> MODULE_LICENSE("GPL v2");
> MODULE_AUTHOR("Intel Corporation");
>
> ---
> base-commit: 2df0193e62cf887f373995fb8a91068562784adc
> change-id: 20240611-nvdimm-test-mod-warn-8cf773360b37
>
> Best regards,
Not on my radar, so thanks for fixing!
Reviewed-by: Jeff Johnson <quic_jjohnson@...cinc.com>
Powered by blists - more mailing lists